New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look Into Closer Coupling of Logical and Arithmetic Rules #25

Closed

eriq-augustine opened this issue Nov 18, 2016 · 1 comment

Labels

Difficulty - Medium Type - Refactor

Owner

eriq-augustine commented Nov 18, 2016

Take a gander and see if they could be made more consistent or shared code can be removed.

I noticed how ground versions of these are made is inconsistent.

ArithmeticRules - makeGroundRule()
LogicalRules - groundFormulaInstance()

eriq-augustine added the Type - Refactor label

eriq-augustine added the Difficulty - Medium label

Owner Author

eriq-augustine commented Nov 7, 2017

I thought about this while doing Lazy Grounding, but did not see any places for closer coupling.

eriq-augustine closed this as completed

eriq-augustine mentioned this issue

[CLOSED] Look Into Closer Coupling of Logical and Arithmetic Rules linqs/psl#72

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment