Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation: Client#addCommandDir, Client#addCommandFile, Client#reloadCommands #88

Open
eritbh opened this issue Aug 22, 2021 · 0 comments · May be fixed by #94
Open

Deprecation: Client#addCommandDir, Client#addCommandFile, Client#reloadCommands #88

eritbh opened this issue Aug 22, 2021 · 0 comments · May be fixed by #94
Labels
deprecation details about deprecated features
Milestone
v3

Comments

@eritbh
Copy link
Owner

eritbh commented Aug 22, 2021 •
edited

The Client methods addCommandDir, addCommandFile, and reloadCommands were all deprecated in #29, when the EventListener class was added. These functions now serve only as aliases for addDir, addFile, and reloadFiles respectively, which means that despite their names, they are not actually limited to working on commands, but impact both commands and event listeners loaded from files. These methods can be directly replaced in consumer code.

addCommandDir, addCommandFile, and reloadCommands will be removed in the 3.0.0 release (#94).
@eritbh eritbh added the deprecation details about deprecated features label Aug 22, 2021
@eritbh eritbh closed this as completed Aug 22, 2021
@eritbh eritbh added this to the v3 milestone Aug 22, 2021
@eritbh eritbh linked a pull request Sep 6, 2021 that will close this issue
V3 deprecation removal #94
Draft
@eritbh eritbh reopened this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation details about deprecated features
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

V3 deprecation removal eritbh/yuuko
1 participant
@eritbh