Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback when importing DOT fails #22

Open
brandly opened this issue Apr 18, 2020 · 0 comments
Open

feedback when importing DOT fails #22

brandly opened this issue Apr 18, 2020 · 0 comments

Comments

@brandly
Copy link
Contributor

brandly commented Apr 18, 2020

looks like the error is swept under the rug with Result.withDefault GF.default

kite/src/Main.elm

Lines 672 to 675 in a5c8fd6

fileContent
|> DotLang.fromString
|> Result.map GraphFile.DotLang.Decode.fromDot
|> Result.withDefault GF.default

any ideas how to display this feedback? i mention this problem and proposed a "toast" system, which we'd have to build out. maybe that's worth doing. maybe there's something else we should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant