ERL-97: eunit run twice tests when both module and module_tests given

[OTP-Maintainer]

Original reporter: crownedgrouse
Affected version: Not Specified
Component: eunit
Migrated from: https://bugs.erlang.org/browse/ERL-97

---

Hi,
I have a module 'xxxx.erl' (no tests in it) and 3 eunit tests in 'xxxx_tests.erl' .

1> eunit:test(['xxxx_tests'],[]).
All 3 tests passed.
ok
2> eunit:test(['xxxx'],[]).
All 3 tests passed.
3> eunit:test(['xxxx_tests','xxxx'],[]).
All 6 tests passed.```

So giving 'xxxx' launch tests in 'xxxx_tests' (documentation explain this ) but giving both modules run twice the tests...

[OTP-Maintainer]

crownedgrouse said:

ping ? :>)

[OTP-Maintainer]

hasse said:

Hi,

I'm not sure I understand. The behaviour seems consistent:

Eshell V9.0  (abort with ^G)
1> eunit:test([eunit]).
  All 6 tests passed.
ok
2> eunit:test([eunit_tests]).
  All 6 tests passed.
ok
3> eunit:test([eunit,eunit]).
  All 12 tests passed.
ok
4> eunit:test([eunit,eunit_tests]).
  All 12 tests passed.
ok

That is, duplicates are never removed.

But I'm not very familiar with eunit, so I might have misunderstood.

Best regards

[OTP-Maintainer]

crownedgrouse said:

Hi,
Issue is that same eunit test run twice. This is particularly annoying with build tools like Erlang.mk which give all modules to eunit, and it is not aware if there is tests in one,  other or both modules. This increases tests times and give a strange report to users, as double number of known tests.
Is there no way to undooblon before running tests ?

[OTP-Maintainer]

crownedgrouse said:

I could undestand 
3> eunit:test([eunit,eunit]).
All 12 tests passed.

or 
3> eunit:test([eunit_tests,eunit_tests]).
All 12 tests passed.

why not, if there is any interrests to do eunit test twice (strange idea, but...).
but not 
4> eunit:test([eunit,eunit_tests]).
All 12 tests passed.

when there is only 6 tests for the module 'eunit'.
Am I clearer ?

[OTP-Maintainer]

richardc said:

The idea was that you shouldn't have to list the x_tests module manually if you have a module x - then just say x and it will run any tests in x and in the corresponding x_tests module if it exists. Only if you have some y_tests module with no actual module y would you have to list y_tests explicitly. But I can see how you might want to automatically just collect a list of all module and pass the names to eunit, and then you would get duplicates. So I think filtering duplicate module names should be done, and it shouldn't be hard to add.

[OTP-Maintainer]

crownedgrouse said:

I wonder however what will happen if some tests are in both module and modules_tests files, if duplicate modules are removed. This something to keep in mind.