ERL-232: httpc:request("https://ssllabs:com:10444") not working correctly

[OTP-Maintainer]

Original reporter: alklasil
Affected version: OTP-19.0
Fixed in version: OTP-19.1
Component: Not Specified
Migrated from: https://bugs.erlang.org/browse/ERL-232

---

*www.ssllabs.com:10444 - (FREAK attack test)*

*Erlang/OTP 19*
httpc:request("https://www.ssllabs.com:10444")
'hangs'

*Erlang/OTP 18*
httpc:request("https://www.ssllabs.com:10444")
{failed_connect,[{to_address,{"www.ssllabs.com",10444}},
                 {inet,[inet],{tls_alert,"unexpected message"}}]}

[OTP-Maintainer]

ingela said:

This patch make it work for me. I need to test some more to make sure I did not break anything else. But it seems there is a "catch all" that should not be there.

diff --git a/lib/ssl/src/ssl_connection.erl b/lib/ssl/src/ssl_connection.erl
index adee593..8a99087 100644
--- a/lib/ssl/src/ssl_connection.erl
+++ b/lib/ssl/src/ssl_connection.erl
@@ -824,8 +824,6 @@ handle_common_event(internal, #change_cipher_spec{type = <<1>>}, StateName,
 		    #state{negotiated_version = Version} = State, Connection) ->
     Connection:handle_own_alert(?ALERT_REC(?FATAL, ?HANDSHAKE_FAILURE), Version, 
 				StateName, State);
-handle_common_event(internal, _, _, _, _) ->
-    {keep_state_and_data, [postpone]};
 handle_common_event(_Type, Msg, StateName, #state{negotiated_version = Version} = State, 
 		    Connection) ->
     Alert =  ?ALERT_REC(?FATAL,?UNEXPECTED_MESSAGE),