ERL-336: -spec of crypto:block_encrypt/4 missing one case for aes_gcm

[OTP-Maintainer]

Original reporter: sdl.web@gmail.com
Affected version: OTP-19.0
Fixed in version: OTP-19.3
Component: crypto
Migrated from: https://bugs.erlang.org/browse/ERL-336

---

The manual entry of crypto:block_encrypt/4 documents the signature block_encrypt(aes_gcm, Key, Ivec, {AAD, PlainText, TagLength}). But the corresponding -spec in crypto.erl does not. So this can cause some dialyzer error like this:

The call crypto:block_encrypt('aes_gcm',CEK::binary(),Nonce::binary(),{<<>>,_,16}) breaks the contract ('des_cbc' | 'des_cfb' | 'des3_cbc' | 'des3_cbf' | 'des3_cfb' | 'des_ede3' | 'blowfish_cbc' | 'blowfish_cfb64' | 'blowfish_ofb64' | 'aes_cbc128' | 'aes_cfb8' | 'aes_cfb128' | 'aes_cbc256' | 'aes_ige256' | 'aes_cbc' | 'rc2_cbc',Key::iodata(),Ivec::binary(),Data::iodata()) -> binary()
    ; ('aes_gcm' | 'chacha20_poly1305',Key::iodata(),Ivec::binary(),{AAD::binary(),Data::iodata()}) -> {binary(),binary()} in the 4th argument

[OTP-Maintainer]

hans said:

Correct, but unfortunately other tasks are prioritized for the near future so I can't fix this right now.

Pull-request anyone?

-Hans

[OTP-Maintainer]

sdl.web@gmail.com said:

I sent in a PR https://github.com/erlang/otp/pull/1311

[OTP-Maintainer]

hans said:

Merged to maint and master