Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERL-604: ssh opaque types are not used in interfaces #3260

Closed
OTP-Maintainer opened this issue Apr 6, 2018 · 1 comment
Closed

ERL-604: ssh opaque types are not used in interfaces #3260

OTP-Maintainer opened this issue Apr 6, 2018 · 1 comment
Assignees
Labels
bug Issue is reported as a bug priority:medium team:PS Assigned to OTP team PS
Milestone

Comments

@OTP-Maintainer
Copy link

Original reporter: okeuday
Affected version: OTP-21.0
Fixed in version: OTP-21.0
Component: ssh
Migrated from: https://bugs.erlang.org/browse/ERL-604


The types available for external use are exported from the {{ssh}} module, like {{ssh:ssh_connection_ref()}} and {{ssh:ssh_channel_id()}}.  However, these types are of limited use due to the internal header file {{ssh_connect.hrl}} containing separate types for {{channel_id()}} and {{connection_ref()}} that are used in external interfaces (e.g., {{ssh_connection:close}}, {{ssh_connection:send}} and {{ssh_connection:send_eof}}).

The types are shown at [ssh_connect.hrl|https://github.com/erlang/otp/blob/master/lib/ssh/src/ssh_connect.hrl#L25-L26] and [ssh.erl|https://github.com/erlang/otp/blob/master/lib/ssh/src/ssh.erl#L60-L61] .  This problem prevents dialyzer checking of source code using the {{ssh_connection}} functions.
@OTP-Maintainer
Copy link
Author

hans said:

Your are right.

However, I'm reworking the types and specs in ssh and have fixed this.  It may (but no promise!) be released in OTP-21.0

@OTP-Maintainer OTP-Maintainer added bug Issue is reported as a bug team:PS Assigned to OTP team PS priority:medium labels Feb 10, 2021
@OTP-Maintainer OTP-Maintainer added this to the OTP-21.0 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is reported as a bug priority:medium team:PS Assigned to OTP team PS
Projects
None yet
Development

No branches or pull requests

2 participants