Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERL-855: prf for DTLS missing #3768

Closed
OTP-Maintainer opened this issue Feb 13, 2019 · 1 comment
Closed

ERL-855: prf for DTLS missing #3768

OTP-Maintainer opened this issue Feb 13, 2019 · 1 comment
Labels
enhancement not a bug Issue is determined as not a bug by OTP priority:medium

Comments

@OTP-Maintainer
Copy link

Original reporter: benbro
Affected version: OTP-21.2.4
Component: ssl
Migrated from: https://bugs.erlang.org/browse/ERL-855


ssl_handshake:prf/6 is missing DTLS:
https://github.com/erlang/otp/blob/master/lib/ssl/src/ssl_handshake.erl#L917

I'm not sure if it's correct but maybe it should like something like:


{code:java}
prf({3,0}, _, _, _, _, _) ->
    {error, undefined};
prf({3,_N}, PRFAlgo, Secret, Label, Seed, WantedLength) ->
+    {ok, tls_v1:prf(PRFAlgo, Secret, Label, Seed, WantedLength)};
+prf({254, 255}, PRFAlgo, Secret, Label, Seed, WantedLength) ->
+    {ok, tls_v1:prf(PRFAlgo, Secret, Label, Seed, WantedLength)};
+prf({254, _}, PRFAlgo, Secret, Label, Seed, WantedLength) ->
+    {ok, tls_v1:prf(PRFAlgo, Secret, Label, Seed, WantedLength)}.
{code}


@OTP-Maintainer
Copy link
Author

ingela said:

DTLS versions correspond to TLS versions, and when this code is called from DTLS the version
will be converted to the corresponding TLS version. DTLS is a diff agianst TLS and common code will
not be DTLS aware.

@OTP-Maintainer OTP-Maintainer added not a bug Issue is determined as not a bug by OTP enhancement priority:medium labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement not a bug Issue is determined as not a bug by OTP priority:medium
Projects
None yet
Development

No branches or pull requests

1 participant