Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDoc swallows errors when running with -chunks #5778

Open
TheGeorge opened this issue Mar 9, 2022 · 1 comment
Open

EDoc swallows errors when running with -chunks #5778

TheGeorge opened this issue Mar 9, 2022 · 1 comment
Assignees
Labels
bug Issue is reported as a bug help wanted Issue not worked on by OTP; help wanted from the community team:VM Assigned to OTP team VM

Comments

@TheGeorge
Copy link
Contributor

TheGeorge commented Mar 9, 2022

Describe the bug
When producing chunks, edoc swallows error messages, and only prints a message, that it failed, but not why.

The issues is here https://github.com/erlang/otp/blob/master/lib/edoc/src/edoc_doclet_chunks.erl#L119-L123

    catch _:_R:_St ->
	?debug("error: ~p\n"
	       "stacktrace:\n~p\n\n", [_R, _St]),
	{OkSet, true}
    end.

and should probably be something like this

    catch throw:{error, Line, {Fmt, Args}}:_St ->
        report(Line, File, Fmt, Args),
	{OkSet, true}
    end.

Expected behavior
Error messages are correctly forwarded to be reported.

Affected versions
current master

@TheGeorge TheGeorge added the bug Issue is reported as a bug label Mar 9, 2022
@rickard-green rickard-green added the team:VM Assigned to OTP team VM label Mar 14, 2022
@rickard-green rickard-green self-assigned this Mar 14, 2022
@garazdawi garazdawi added the help wanted Issue not worked on by OTP; help wanted from the community label Oct 3, 2022
@garazdawi
Copy link
Contributor

Putting this in "help wanted" as #5779 seems to have stalled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is reported as a bug help wanted Issue not worked on by OTP; help wanted from the community team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants