erts: Fix -oldshell and -noshell on Windows #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
force-pushed
the
lukas/erts/fix-windows-oldshell
branch
from
b5401ef
to
56c244d
Compare
CT Test Results 4 files 187 suites 1h 50m 5s ⏱️ For more details on these failures, see this check. Results for commit ee2f6e6. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/erts/fix-windows-oldshell
branch
3 times, most recently
from
ad3d7a7
to
22287c2
Compare
garazdawi
added
the
testing
garazdawi
force-pushed
the
lukas/erts/fix-windows-oldshell
branch
from
ee2f6e6
to
8ef088b
Compare
When not using a terminal we need to use ReadFile to read from stdin. Before this fix we only used ReadFile if stdin was not a terminal, but the same behaviour should be used if we disable the terminal using flags to erl.exe. Fixes erlang#7324
garazdawi
force-pushed
the
lukas/erts/fix-windows-oldshell
branch
from
8ef088b
to
d9ef5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using a terminal we need to use ReadFile to read from stdin. Before this fix we only used ReadFile if stdin was not a terminal, but the same behaviour should be used if we disable the terminal using
flags to erl.exe.
Fixes #7324