Add the hello module as a test case #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
lhoguin
reviewed
Apr 15, 2021
| ok. | ||
|
|
||
| test_catches() -> | ||
| thrown = (catch do_throw(id(thrown))), |
There was a problem hiding this comment.
I'm sure you know this so feel free to ignore me, but after #4736 gets merged you can drop the parentheses (4 instances of this in the file).
There was a problem hiding this comment.
Removed the parentheses. (#4736 is not needed because it fixes pretty-printing and documentation, while the actual change to erl_parse was done in a previous commit.)
bjorng
force-pushed
the
bjorn/erts/hello
branch
from
82d2ba5
to
98a8792
Compare
bjorng
added
testing
When developing a JIT, or a new implementation of Erlang, or a new compiler for Erlang, one usually writes multiple small test cases to use during development. Usually all that testing code is discarded afterwards. To avoid having to come up with those tests from scratch the next time such a task is attempted, this commit adds a `hello` module that tests most constructs that an Erlang implemenation needs to handle. To ensure that it keeps working, we will embed it into a test suite for the ERTS application.
bjorng
force-pushed
the
bjorn/erts/hello
branch
from
98a8792
to
03dd385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing a JIT, or a new implementation of Erlang, or a
new compiler for Erlang, one usually writes multiple small test cases
to use during development. Usually all that testing code is discarded
afterwards.
To avoid having to come up with those tests from scratch the next time
such a task is attempted, this commit adds a
hellomodule that testsmost constructs that an Erlang implemenation needs to handle. To ensure
that it keeps working, we will embed it into a test suite for the
ERTS application.