Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove install rules from tests and demos #21

Open
ricortiz opened this issue Aug 19, 2020 · 7 comments
Open

Remove install rules from tests and demos #21

ricortiz opened this issue Aug 19, 2020 · 7 comments

Comments

@ricortiz
Copy link
Collaborator

Arguably the OT distribution package should only contain the library itself and the CMake machinery find the package and import the OpenTissue target. If users want to run demos then we should instruct them to go over the build process.

@erleben Thoughts?

@ricortiz ricortiz added the cmake label Aug 19, 2020
@ricortiz ricortiz added this to To do in Refactoring via automation Aug 19, 2020
@erleben
Copy link
Owner

erleben commented Aug 19, 2020

I agree with you that OT library + CMake is the main parts that make up an OT package.

I am thinking Conan part can be incorporated into the CMake magic workflow. Either guiding users by introspection and meaningful warnings or simply running the Conan install think as a pre-step for the whole CMake thing.

I am also thinking that there are deps on two different levels, those that are used by OT library functions and those that are used by demos/unit-tests. I am in two minds whether they should be treated independently.

@erleben
Copy link
Owner

erleben commented Aug 19, 2020

That is I support nuking the install rules for unit-tests and demos

@ricortiz
Copy link
Collaborator Author

Conan can indeed be incorporated into the CMake build system. I have been thinking on a way to do it that will also allow folks to build OT aps without conan.

Ref.

Launch conan from within cmake.

@ricortiz ricortiz changed the title Remove install rules for tests and demos Remove install rules from tests and demos Aug 20, 2020
@ricortiz
Copy link
Collaborator Author

ricortiz commented Aug 20, 2020

So here is the dependency breakdown as I see it:

  • OpenTissue
  • Boost
  • TetGen
  • Triangle
  • Qhull
  • TinyXML --> this probably should not be a dependency of the core library
  • DevIL
  • unit_test
  • Same as OT
  • demos
  • Same as OT
  • GLUT, GLEW and OpenGL

@erleben
Copy link
Owner

erleben commented Aug 20, 2020

We got a bit of devIL as well?

@erleben
Copy link
Owner

erleben commented Aug 20, 2020

The Conan cmake integration seems like a nice solution. It will make it easier for new unexperienced C++ developers to get into OT. Experienced developers can always just dig into the nasty parts, no need to worry about them:-)

@ricortiz
Copy link
Collaborator Author

yeah, forgot DevIL...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Refactoring
  
To do
Development

No branches or pull requests

2 participants