Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly specify the minimum requirement for OTP26 #296

Closed
jozuas opened this issue Dec 5, 2023 · 4 comments · Fixed by #298
Closed

Clearly specify the minimum requirement for OTP26 #296

jozuas opened this issue Dec 5, 2023 · 4 comments · Fixed by #298
Assignees
Milestone

Comments

@jozuas
Copy link
Contributor

jozuas commented Dec 5, 2023

Description

There is no communication in this project on the fact that a minimum Erlang OTP version 26 is required.

** (exit) an exception was raised:
    ** (UndefinedFunctionError) function :base64.encode/2 is undefined or private

base64.encode/2 was introduced in OTP 26

versions:

  • oidc: 3.1.0
  • Elixir 1.15.7 with Erlang 25.3.2.7
@maennchen
Copy link
Member

The version is specified for rebar:

{minimum_otp_vsn, "26"}.

Unfortunately, mix does not have a field to do the same thing.

@jozuas jozuas changed the title Clerly specify the minimum requirement for OTP26 Clearly specify the minimum requirement for OTP26 Dec 5, 2023
@jozuas
Copy link
Contributor Author

jozuas commented Dec 5, 2023

Thanks a lot for your quick response. I've bumped the discussion on this topic on the elixir forum https://elixirforum.com/t/specifying-minimal-erlang-version-in-mix-exs/39911/13?u=jozuas.

For the time being maybe having a visible section in the README.md on how "OTP26 or above is required" would ensure a smoother experience for Elixir users?

@maennchen
Copy link
Member

@jozuas A PR for the README would be welcome 👍

Would you provide one?

If yes: make sure the section looks good both on GitHub and also in the docs since the README is included there as well.

@jozuas
Copy link
Contributor Author

jozuas commented Dec 5, 2023

Sure, I will do later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants