Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description should not read "Click here for additional data file." #90

Open
Daniel-Mietchen opened this issue Jul 27, 2013 · 5 comments

Comments

@Daniel-Mietchen
Copy link
Member

For a week or so, the bot gets the file descriptions wrong, apparently by mixing up the captions for the article element (Movie S1 in the example below) and for the media file itself (pone.0022479.s004.wmv), yielding "Click here for additional data file."

http://eutils.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi?db=pmc&id=3150374
http://commons.wikimedia.org/w/index.php?title=File:Some-Causes-of-the-Variable-Shape-of-Flocks-of-Birds-pone.0022479.s004.ogv&oldid=100751536

<supplementary-material content-type="local-data" id="pone.0022479.s004">
<label>Movie S1</label>
<caption>
<p>
<bold>Measurement of school shape.</bold>
This movie shows a bounding box around the flock in black. Its dimensions are calculated with the PCA. The the shortest dimension is the height. The flock is clearly asymmetrical or oblong. Simultaneously the movie shows the bounding box for measuring the degree to which the flock is elongated in the movement direction (white).
</p>
<p>(WMV)</p>
</caption>
<media xlink:href="pone.0022479.s004.wmv" mimetype="video" mime-subtype="x-ms-wmv">
<caption>
<p>Click here for additional data file.</p>
</caption>
</media>
</supplementary-material>
@ghost ghost assigned erlehmann Jul 27, 2013
@erlehmann
Copy link

There are two caption elements. What is the difference between them? I'll add an assertion that „Click here“ should not be part of a caption at all.

@erlehmann
Copy link

The responsible commit is most probably 904a84f.

@erlehmann
Copy link

I thought that was a legitimate caption. #84 (comment) Should I revert 904a84f?

@erlehmann
Copy link

e5e8479 now throws an AssertionError when this happens. Leaving this bug open until it is clear if 904a84f should be reverted.

@erlehmann
Copy link

Reverted 904a84f as of 7c66e37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants