Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: what's the best practice of installing Relx script - copy to each repo or install globally? #31

Closed
nivertech opened this issue Sep 10, 2013 · 6 comments

Comments

@nivertech
Copy link

No description provided.

@tsloughter
Copy link
Member

I'd say there isn't one currently. Globally would be the way to go eventually but not the best way to go if you mean public repos. Private projects it makes sense to just have relx installed globally.

@blt
Copy link

blt commented Sep 10, 2013

Personally, I like to keep rebar/relx out of repositories and have them be a system dependency. With rebar especially I've found that bundled versions tend to have incompatible bytecode on TravisCI and depending on how your Makefile is written you're at the mercy of individual developer's PATH order.

There are trade-offs both ways, of course, and what works is largely a matter of context.

@tsloughter
Copy link
Member

A nice way I've seen with rebar is to do this in your Makefile:

REBAR=$(shell which rebar)

ifeq ($(REBAR),)
REBAR=$(CURDIR)/rebar
endif

$(REBAR):
    wget https://github.com/rebar/rebar/wiki/rebar
    chmod a+x rebar

I'll need to make a release off relx to put up with github's new releases feature and then we could do that for relx as well.

@nivertech
Copy link
Author

I have shell scripts like this:

REBAR=`which rebar || echo ./rebar`
$REBAR skip_deps=true compile

probably a good idea to use something similar for relx.

RELX=`which relx || echo ./relx`
$RELX ...

BTW: I think rebar got initial traction by being copied into many open source repos. Only when it was almost de-facto standard they recommended to start installing it globally.

@tsloughter
Copy link
Member

Yup, that is why we went this way with relx and had converted sinan to an escript as well near its end of life. So going to same route with relx.

Shall I close this ticket?

@nivertech
Copy link
Author

yes. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants