Fix catch-all exception clause in parse_resources_directory #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular call to PE.get_data() was not in a try-catch block and caused an uncaught PEFormatError exception when parsing malware sample 4cf7e36c5ef5b37f3231740794fecdaec5635b176320288a50694ca5be7ac898 (32-bit PE). PE.get_data() attempts to read from RVA 0xffe93eb8 which is invalid.
|
I can verify both the issue and that it works fine with the patch. |
|
PR #166 already addressed most of this PR, but includes a catch-all exception clause. This PR now limits the exception to PEFormatError. |
tdube
changed the title
tdube
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular call to PE.get_data() was not in a try-catch block and caused an uncaught PEFormatError exception when parsing malware sample 4cf7e36c5ef5b37f3231740794fecdaec5635b176320288a50694ca5be7ac898 (32-bit PE). PE.get_data() attempts to read from RVA 0xffe93eb8 which is invalid.