Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Code that Updates Window #2

Closed
1 of 7 tasks
Eronan opened this issue Sep 5, 2022 · 1 comment
Closed
1 of 7 tasks

Remove Code that Updates Window #2

Eronan opened this issue Sep 5, 2022 · 1 comment

Comments

@Eronan
Copy link
Owner

Eronan commented Sep 5, 2022 •
edited

Refactor all Logic that updates the .xaml Window and instead update Bindings in the Code-Behind.

Notable Instances:

  • Deck ListBox Creation
  • MenuItem_Import IsEnabled
  • AdvancedSearch Button IsEnabled
  • MenuItem_Export IsEnabled
  • DeckBuilder Window Title
  • Bind DataTrigger to Property in LoadPlugin.xaml.cs
  • AdvancedSearch Search List Controls.
@Eronan
Copy link
Owner Author

Eronan commented Sep 6, 2022

Heavy Performance Issues caused by attempting to use ViewModel.
AdvancedSearch Window will attempt to use a ViewModel. However, DeckBuilder will avoid a ViewModel.

@Eronan Eronan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eronan