Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A list of supported and unsupported (todo) features #8

Open
rishabh413 opened this issue Apr 12, 2023 · 7 comments
Open

A list of supported and unsupported (todo) features #8

rishabh413 opened this issue Apr 12, 2023 · 7 comments

Comments

@rishabh413
Copy link

Hi

Thanks for providing this library. I am looking to use it in my projects. The "About" section of the library says "(under development)". I am assuming there are some features of 2020-12 which are missing in it right now.

Is there a list detailing supported and unsupported features? Such a list will help in tracking progress and help contributors effectively contribute to this library.

@erosb
Copy link
Owner

erosb commented Apr 13, 2023

Hello @rishabh413 , thank you for your interest in the project.

Currently the library is fairly close to be compliant with the specification, it is tested against the official test suite and 1181 tests pass out of 1199. You can run the testsuite with mvn clean test -Dgroups=acceptance. These are mostly $dynamicRef and $dynamicAnchor related tests.

The current priorities are:

Once these are done, I plan to migrate some more features from the old project:

Please let me know if you are interested in working on any of these and I can elaborate further.

@ledex
Copy link

ledex commented Jan 9, 2024

Hi @erosb! Can you provide an update on the open topics and their current priority? We are also thinking about using your libary and are wondering A) in which stat it is and B) how we can help you.

Cheers
Karsten

@erosb
Copy link
Owner

erosb commented Jan 9, 2024

Hello @ledex, compared to the previous list: "format" support was added, which is probably relevant for most people.

My top concern right now, from the compliance perspective, is $dynamicRef / $dynamicAnchor support, but TBH that's a complicated topic (total nightmare, in other words).

Regarding other features, I'm open to any suggestions. What would be most important for you? We can align on the priorities.

@alturkovic
Copy link

Regarding format, it would be very useful to register our custom format validators. For an example, the current implementation does not validate hostnames. Also, the current implementation depends on a vulnerable dependency (commons-validator). If registering custom implementations was possible, we could exclude that dependency and provide our own implementations for email and inet-address formats as well as hostname validator.

Would it be possible to register our own implementation to support it?

@erosb
Copy link
Owner

erosb commented Mar 15, 2024

Hello @alturkovic can you please take a look if #71 works for you?
I also pushed a java code sample to erosb/json-sKema-examples@master...custom-format#diff-4fe3b194596bdf1d22243548b0e840c929c42751cea73fb3785810e8d66c3f87R12 . Please review and let me know if we can merge & release it, thanks.

@alturkovic
Copy link

LGTM 👍

@erosb
Copy link
Owner

erosb commented Mar 16, 2024

@alturkovic version 0.14.0 is now available on maven central with the custom format validation support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants