Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /problems?exclude_apps=app1,app2 feature #1354

Merged
merged 4 commits into from Aug 17, 2018

Conversation

burnettk
Copy link
Contributor

@burnettk burnettk commented Aug 7, 2018

...to make problems page usable with noisy apps

this is the other half of #1273 , which i am declining since i did a rebase and added a bunch of commits that i didn't want somehow.

@rud rud added the feature label Aug 7, 2018
@stevecrozz
Copy link
Member

I do want better filtering and I think this option is useful, but I'd like to consider it as part of a more ambitious filtering scheme. I'm inspired by the filtering options we use right here on github issues. Here's an example of a filter + exclusion search: https://github.com/errbit/errbit/issues?utf8=%E2%9C%93&q=author%3Astevecrozz+-label%3Abug+

@burnettk: Can you think of a way to add the app exclusion filter you want while working toward a future where we have a coherent filtering grammer like github's?

The first thing that comes to my mind is a search like -app:app1 -app:app2. Does that seem reasonable?

@burnettk
Copy link
Contributor Author

did it!

@stevecrozz
Copy link
Member

Seems good @burnettk. Not sure what's going on with Coveralls, but all the new lines you added are covered, so that shouldn't be an issue.

@rud
Copy link
Contributor

rud commented Aug 17, 2018

Cool, merging

@rud rud merged commit 44ff2b9 into errbit:master Aug 17, 2018
@stevecrozz stevecrozz added this to the 0.8.0 milestone Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants