Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binstubs fixes and cleanup #1522

Merged
merged 3 commits into from Jun 6, 2022

Conversation

biow0lf
Copy link
Contributor

@biow0lf biow0lf commented Jun 5, 2022

This is part of rails 7 changes that are not for rails 7 itself.

  1. Remove useless bundler binstubs. Like: bin/byebug, bin/haml, etc. Nobody use them while development or production.
  2. Fix ruby version in dokku installation documentation.
  3. Regenerate bin/rails and bin/rake via rake rails:update:bin. This is fix production rails console:
/app # rails c
Looks like your app's ./bin/rails is a stub that was generated by Bundler.

In Rails 4, your app's bin/ directory contains executables that are versioned
like any other source code, rather than stubs that are generated on demand.

@biow0lf
Copy link
Contributor Author

biow0lf commented Jun 5, 2022

@stevecrozz can you review and merge?

@burnettk
Copy link
Contributor

burnettk commented Jun 6, 2022

It's possible someone was depending on the binstubs instead of running bundle exec. that person is not me, and we could always add them back if anyone wants them. approved. :)

@stevecrozz
Copy link
Member

I think you're right @biow0lf. I certainly don't use any of those binstubs that were deleted.

@stevecrozz stevecrozz merged commit c1cec0a into errbit:main Jun 6, 2022
@stevecrozz stevecrozz added this to the 0.10.0 milestone Jun 6, 2022
@biow0lf biow0lf deleted the binstubs-fixes-and-cleanup branch June 7, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants