Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Registry Bounce #15

Closed
Noggog opened this issue Sep 5, 2021 · 2 comments
Closed

Add Registry Bounce #15

Noggog opened this issue Sep 5, 2021 · 2 comments

Comments

@Noggog
Copy link

Noggog commented Sep 5, 2021

Just pitching the idea of adding registry support. Currently mutagen uses GameFinder, but only if it cannot locate an installation in the registry:
https://github.com/Mutagen-Modding/Mutagen/blob/cf708daf0b89c643b94bf08c28e7ab2a719d9451/Mutagen.Bethesda.Core.Windows/Installs/DI/GameLocator.cs#L50

Might be nice to just bubble that up to this lib? Is there a specific reason registries are not considered?

This would also help with WJ "stock game" installs, which you can see some discussions here:
https://discord.com/channels/759302581448474626/883872997214158909/883872999562960906
https://discord.com/channels/605449136870916175/623261438022254612/883870322581962792

@Noggog Noggog mentioned this issue Sep 5, 2021
@erri120
Copy link
Owner

erri120 commented Sep 5, 2021

What exactly do you mean with

registry support

Most of the packages already access the registry to find the the Store installation, installed games or both.

@Noggog
Copy link
Author

Noggog commented Sep 5, 2021

Mutagen has code to look at the registry for SOFTWARE\WOW6432Node\Bethesda Softworks\Skyrim Special Edition, as a lot of people complained their games weren't being located when just GameFinder was being used by itself. I was under the impression that GameFinder only returns results from the steam library files, and doesn't look for that registry key ^

Currently my logic is that I look in that registry first, and if it's not found, then I use GameFinder to search the steam installations

@erri120 erri120 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants