Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on first launch #36

Closed
crookedstorm opened this issue Oct 20, 2016 · 5 comments
Closed

Crash on first launch #36

crookedstorm opened this issue Oct 20, 2016 · 5 comments
Assignees
@jpbruinsslot
Labels
bug
Milestone
v0.2.2

Comments

@crookedstorm
Copy link

On the first launch on macOS Sierra, I got this:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x161603]

goroutine 16 [running]:
panic(0x291780, 0xc42000a0b0)
    /usr/local/go/src/runtime/panic.go:500 +0x1a1
golang.org/x/net/websocket.(*Conn).SetWriteDeadline(0x0, 0xecf9b4673, 0x329892cc, 0x431b60, 0xc420168380, 0x0)
    /home/jp/go/src/golang.org/x/net/websocket/websocket.go:269 +0x43
github.com/nlopes/slack.(*RTM).connect(0xc42008fc20, 0x1, 0x0, 0x0, 0x0, 0x0)
    /home/jp/go/src/github.com/nlopes/slack/websocket_managed_conn.go:94 +0x266
github.com/nlopes/slack.(*RTM).ManageConnection(0xc42008fc20)
    /home/jp/go/src/github.com/nlopes/slack/websocket_managed_conn.go:32 +0x44
created by github.com/erroneousboat/slack-term/src/service.NewSlackService
    /home/jp/go/src/github.com/erroneousboat/slack-term/src/service/slack.go:36 +0x42d

I just thought I'd report the crash. On second launch all is well, and I cannot currently reproduce this.
@jpbruinsslot jpbruinsslot self-assigned this Oct 21, 2016
@jpbruinsslot
Copy link
Owner

Happens to me sometimes as well. It probably has something to do with not able to start the connection to slack. I'll have a look, thanks.

@jpbruinsslot jpbruinsslot added this to the v0.1.0 milestone Oct 21, 2016
@jpbruinsslot
Copy link
Owner

This should at least give a sensible error message when the connection to slack can't be established. However I'm not certain if this solves this particular problem, I'll have to see if it'll happen again in the future.

@henriquechehad henriquechehad mentioned this issue Nov 4, 2016
Closed
@henriquechehad
Copy link

same issue here

@jpbruinsslot jpbruinsslot reopened this Nov 4, 2016
@jpbruinsslot
Copy link
Owner

@henriquechehad thanks for the heads up, still happens to me on occasion.

@jpbruinsslot jpbruinsslot added this to the v0.3.0 milestone Nov 7, 2016
@jpbruinsslot jpbruinsslot modified the milestones: v0.2.2, v0.3.0 Jul 16, 2017
@jpbruinsslot
Copy link
Owner

Closed due to age

jpbruinsslot added a commit that referenced this issue Dec 23, 2017
@jpbruinsslot
Move authTest before creation of RTM
7a4dbd4 
By moving authTest we'll be able to test the connection to
slack, and return a sensible error message when this fails.

Fixes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpbruinsslot jpbruinsslot

Labels
bug
Projects
None yet
Milestone
v0.2.2
Development

No branches or pull requests
3 participants
@jpbruinsslot @henriquechehad @crookedstorm