Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃悎 Task]: Add a test to check dockerized model works before pushing the model image to DockerHub #1096

Closed
DhanshreeA opened this issue Apr 3, 2024 · 2 comments
Closed

[馃悎 Task]: Add a test to check dockerized model works before pushing the model image to DockerHub #1096

DhanshreeA opened this issue Apr 3, 2024 · 2 comments
Assignees
@DhanshreeA
Labels
critical Critical issue that is a blocker and we need to solve immediately; use sparingly enhancement New feature or request

Comments

@DhanshreeA
Copy link
Member

DhanshreeA commented Apr 3, 2024 •
edited

Summary

For some models we are experiencing errors with Dockerized models such as RunTime errors during prediction, or Null outputs. Eg: ersilia-os/zaira-chem#36 (comment)

Objectives

While this could be due to any number of issues, eg, such as #1051 however we should still run a prediction test for a dockerized model in our Build and push to DockerHub pipeline before a model image is pushed to DockerHub.

Documentation

No response
@DhanshreeA DhanshreeA added the enhancement New feature or request label Apr 3, 2024
@DhanshreeA DhanshreeA self-assigned this Apr 3, 2024
@DhanshreeA DhanshreeA added the critical Critical issue that is a blocker and we need to solve immediately; use sparingly label Apr 3, 2024
@miquelduranfrigola
Copy link
Member

I completely agree with this, @DhanshreeA , and I agree it is critical

@DhanshreeA DhanshreeA mentioned this issue Apr 8, 2024
Closed
@DhanshreeA DhanshreeA changed the title 馃搼 Feature Request: Add a test to check dockerized model works before pushing the model image to DockerHub [馃悎 Task]: Add a test to check dockerized model works before pushing the model image to DockerHub May 28, 2024
@DhanshreeA
Copy link
Member Author

This is handled in the eos-template repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DhanshreeA DhanshreeA

Labels
critical Critical issue that is a blocker and we need to solve immediately; use sparingly enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DhanshreeA @miquelduranfrigola