Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Consider to delete MDBX_BUILD_TIMESTAMP #201

Closed
AskAlexSharov opened this issue Jun 1, 2021 · 2 comments
Closed

Consider to delete MDBX_BUILD_TIMESTAMP #201

AskAlexSharov opened this issue Jun 1, 2021 · 2 comments
Assignees

Comments

@AskAlexSharov
Copy link
Contributor

There is no logic based on this constant.

But it breaks reproducibility of app builds: shasum -a256 mybinary is different from build to build only because of MDBX_BUILD_TIMESTAMP.
Reproducibility checksum useful for security reasons - to check that no malware code was embedded into app sources during "release binary artifacts" process.

@erthink
Copy link
Owner

erthink commented Jun 2, 2021

It was assumed that the ability to predefine MDBX_BUILD_TIMESTAMP for builds reproducibility would be added.
Looks like it's time to do it.

@AskAlexSharov
Copy link
Contributor Author

It works:

MDBX_BUILD_TIMESTAMP=unknown make config.h
make mdbx-static.o

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants