Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication with Github, Microsoft not working due to timeout #38

Closed
aszabo314 opened this issue Mar 29, 2018 · 3 comments
Closed

Authentication with Github, Microsoft not working due to timeout #38

aszabo314 opened this issue Mar 29, 2018 · 3 comments
Labels

Comments

@aszabo314
Copy link

aszabo314 commented Mar 29, 2018

We are unable to log in to either para or scoold using github authentication. After granting privileges to the respective app on github, the process appears to simply time out, after which paraio.com shows the message "Authentication failed or was cancelled."

Is there anything obvious we're missing? Does this authentication work on your end?

Edit: We also experience this issue with Microsoft auth.

@albogdano
Copy link
Member

This has been happening for some time now and I can't figure out what exactly causes it. The affected OAuth providers are GitHub and Microsoft. The request which times out is the one querying the user profile from the respective identity provider. I'll have to investigate this further.

@albogdano albogdano added the bug label Mar 29, 2018
@albogdano albogdano changed the title Authentication with Github not working/timeout Authentication with Github, Microsoft not working due to timeout Mar 29, 2018
@aszabo314
Copy link
Author

Appears to work now again - we have no more problems with authenticating.

@albogdano
Copy link
Member

The recent changes in 4787631 seem to have fixed this issue. Not properly closing HttpClient resources could have been the root cause. Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants