-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
em and strong fail if html with _ inside #107
Comments
Similar case
Pasedown does not handle these cases correctly. |
Another case
FOO GFM also fail to parse it. http://johnmacfarlane.net/babelmark2/?text=**%5B**FOO**%5D(%2Furl%2F)** |
This last case is a bit different as strong in strong is not supposed to be supported in any case. |
@Cerdic all examples are correctly rendered by the Markdown 1.0.2b8 |
@wkpark ok my bad ! |
Closing for the reasons outlined in #588 |
Too bad :( I understand that the patch doesn't fix all cases, especialy the one described in #588 but I think that ignoring html tags in the regexp as proposed gives a much better robustness for a not a such perf impact. |
What happens if you try something like |
it fails :( |
If there were an easy fix for most cases then I'd definitely be up for getting Parsedown to behave a bit better. I think the regex only really addresses the specific case of delimiters between angle brackets though (which is fine if that's all you need! :) ). Sure, we could patch the regex to try to find closing tags, but then what about |
This test case works fine
___em strong <a href="http://parsedown.org/" class='externallink'>Parsedown</a>___
Whereas this fails
___em strong <a href="http://parsedown.org/" class='external_link'>Parsedown</a>___
The text was updated successfully, but these errors were encountered: