Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Model not valid (v4) #54

Closed
majora2007 opened this issue Jun 25, 2023 · 2 comments · Fixed by #55
Closed

Review Model not valid (v4) #54

majora2007 opened this issue Jun 25, 2023 · 2 comments · Fixed by #55

Comments

@majora2007
Copy link
Contributor

Looking at https://api.jikan.moe/v4/anime/1/reviews, you can see the json below. However, the model currently has properties that are no longer there, like votes, ReviewScores, and missing important fields like Score and IsSpoiler.

However I noticed multiple tests testing against Votes, despite the payload not having it. Thoughts? I need to be able to get the score of the review, however current version is always having Overall as 0.

Note: I have already coded up the model and can raise a PR if needed.

{
            "mal_id": 7406,
            "url": "https://myanimelist.net/reviews.php?id=7406",
            "type": "anime",
            "reactions": {
                "overall": 2156,
                "nice": 2136,
                "love_it": 9,
                "funny": 1,
                "confusing": 1,
                "informative": 5,
                "well_written": 4,
                "creative": 0
            },
            "date": "2008-08-24T05:46:00+00:00",
            "review": "...",
            "score": 10,
            "tags": [
                "Recommended"
            ],
            "is_spoiler": false,
            "is_preliminary": false,
            "episodes_watched": null,
            "user": {
                "url": "https://myanimelist.net/profile/TheLlama",
                "username": "TheLlama",
                "images": {
                    "jpg": {
                        "image_url": "https://cdn.myanimelist.net/s/common/userimages/35fb5f95-6a86-498b-93a5-fcff7f402bc2_42x62_i?s=31842eb777c5fc3e5a4324250440ae95"
                    },
                    "webp": {
                        "image_url": "https://cdn.myanimelist.net/s/common/userimages/35fb5f95-6a86-498b-93a5-fcff7f402bc2_42x62_i?s=31842eb777c5fc3e5a4324250440ae95"
                    }
                }
            }
        },
@Ervie
Copy link
Owner

Ervie commented Jul 7, 2023

Thanks, it was helpful. Your changes should be visible in package version 2.6.1

@majora2007
Copy link
Contributor Author

Thanks, appreciate the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants