Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualized renderer for syntax higlighter #217

Open
erykpiast opened this issue Jan 6, 2020 · 1 comment · May be fixed by #218
Open

Virtualized renderer for syntax higlighter #217

erykpiast opened this issue Jan 6, 2020 · 1 comment · May be fixed by #218
Assignees
Labels
refactor Purely technical task
Projects
Milestone

Comments

@erykpiast
Copy link
Owner

Syntax highlighting of long files (like >1000 lines) may significantly decrease framerate. There is a package called react-syntax-highlighter-virtualized-renderer created to resolve exactly this issue, but it needs some fine-tuning. At the moment line numbers don't work with this renderer.

There is an issue open for this, must be resolved. PR seems doable.

@erykpiast erykpiast added the enhancement New feature or request label Jan 6, 2020
@erykpiast erykpiast added this to the v1 milestone Jan 6, 2020
@erykpiast erykpiast added this to To do in default via automation Jan 6, 2020
@erykpiast erykpiast self-assigned this Jan 7, 2020
@erykpiast erykpiast added refactor Purely technical task and removed enhancement New feature or request labels Jan 25, 2020
@erykpiast
Copy link
Owner Author

erykpiast commented Feb 5, 2020

There is good but also bad news.
The good one: line numbers are not an issue anymore! They're rendered as a part of the line, so it works perfectly with the virtualized renderer.
The bad: modified files are displayed with a different viewer, which doesn't support the linked package. It may (but doesn't have to) become a truth for added and removed packages as well (after resolving #233).

@erykpiast erykpiast moved this from To do to In progress in default Feb 5, 2020
@erykpiast erykpiast modified the milestone: v1 Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Purely technical task
Projects
default
  
In progress
Development

Successfully merging a pull request may close this issue.

1 participant