Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push command progress don't count correctly #4

Open
fw2568 opened this issue Feb 4, 2024 · 0 comments
Open

Push command progress don't count correctly #4

fw2568 opened this issue Feb 4, 2024 · 0 comments
Assignees

Comments

@fw2568
Copy link
Member

fw2568 commented Feb 4, 2024

The current implementation of the bytes transferred counter in the push command works by reporting all bytes read from the source stream.

However, this doesn't work properly if bytes are read multiple times, most likely because some were rejected by the backend hash check and are being repeated. In this case, the number of bytes read will keep increasing, even if we have already reached 100%.

The implementation should be updated to prevent this problem. One solution might be to add a new progress step for repeated transfers, or to reset the count in case of a repeat.

AB#598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants