Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flash Implementation for new Hardware Iteration #219

Closed
DavidFederl opened this issue May 23, 2024 · 3 comments · Fixed by #221
Closed

Fix Flash Implementation for new Hardware Iteration #219

DavidFederl opened this issue May 23, 2024 · 3 comments · Fixed by #221
Assignees
Labels
bug Something isn't working hardware hardware related issues

Comments

@DavidFederl
Copy link
Contributor

DavidFederl commented May 23, 2024

The new hardware Iteration features a larger flash with 256MB. This shouldn't be a problem, but the sector and page size has also changed!

We now have only 64KiB sectors instead of 256KiB and the page size is reduced from 512B to 256B.

The implementation has to catch this stuff. We Should provide this inside a config file instead of the actual flash library.
The flash library should then only check if the FLASH_BYTES_PER_PAGE and FLASH_BYES_PER_SECTOR are defined and if not exit with error.


Old OPN:
-> S25FL128SAIVF01
New OPN:
-> S25FL256SAIF00

@DavidFederl DavidFederl added bug Something isn't working hardware hardware related issues labels May 23, 2024
@DavidFederl
Copy link
Contributor Author

In Addition to #211

@DavidFederl
Copy link
Contributor Author

Maybe we should use the ICF read to properly setup the library without requiring user input.

@DavidFederl
Copy link
Contributor Author

DavidFederl commented Jun 4, 2024

Maybe we should use the ICF read to properly setup the library without requiring user input.

This can be accomplished by passing a configuration (struct) to each function call which holds all required values. Values like

  • Page Size
  • Sector Size
  • Total Memory

Can best set inside the flashInit(...) function. Whereas values like

  • SPI module
  • GPIOs

Should be set by the user.

@DavidFederl DavidFederl linked a pull request Jun 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hardware hardware related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants