Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest versions #23

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Update dependencies to latest versions #23

merged 1 commit into from
Dec 21, 2017

Conversation

es128
Copy link
Member

@es128 es128 commented Dec 14, 2017

@coveralls
Copy link

coveralls commented Dec 14, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 59a9101 on bump-major into a16f5bd on master.

@phated
Copy link
Member

phated commented Dec 16, 2017

@es128 👍 it looks like the failure was a failure with reaching the coveralls API.

Do you want to mention anything about escaping in the readme?

@phated
Copy link
Member

phated commented Dec 20, 2017

@es128 hate to keep poking but what do you think here?

Also, what are your thoughts on putting this in the micromatch org?

cc @jonschlinkert @doowb

@es128
Copy link
Member Author

es128 commented Dec 20, 2017

I'm fine with moving it to the org. Do you have a suggested patch for the readme?

@phated
Copy link
Member

phated commented Dec 20, 2017

I think we can just mention that the latest micromatch handles backlashes differently and link to https://github.com/micromatch/micromatch#backslashes

@phated
Copy link
Member

phated commented Dec 20, 2017

@es128 #24

@es128
Copy link
Member Author

es128 commented Dec 20, 2017

@phated just gonna give it about a day to see if @jonschlinkert wants to weigh in. If no dissent, I'll merge, publish, and transfer the repo over to the micromatch org (maybe the last one first).

Feel free to ping me if I forget.

@jonschlinkert
Copy link
Member

transfer the repo over to the micromatch org

awesome!

I'm good with everything mentioned!

@phated
Copy link
Member

phated commented Dec 21, 2017

Perfect! @es128 I appreciate your work here.

@phated
Copy link
Member

phated commented Dec 21, 2017

@es128 still able to tackle this today?

@es128
Copy link
Member Author

es128 commented Dec 21, 2017

Yup

@es128 es128 merged commit 96f3ec6 into master Dec 21, 2017
@phated
Copy link
Member

phated commented Dec 21, 2017

master failed just due to the org change. Coveralls needs to get set up for the micromatch org

@es128
Copy link
Member Author

es128 commented Dec 21, 2017

already done

@es128 es128 deleted the bump-major branch December 21, 2017 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants