Add L2 networks - basic #151

rahul-kothari · 2021-09-01T17:05:23Z

Note-
Still need to add styling and tests

What was wrong?

How was it fixed?

Cute Animal Picture

…t, add venv to gitignore

add version range for eth-hash in setup.py remove addresses.txt in gitignore

…y for multiple networks Remove SAI and use DAI for L1

…token like functionality

…t), validation, comments, mappings, payments - rename TOKEN_RATES, fix bugs, reduce functionality

with such a great and generic helpers, there is no need repeat the `payment_instructions` method its only change was if it was using or not the chain_id and used token address or not which is all covered in the helpers already

…nitions simplify token class definitions

add token based classes and refactor till payment options

Add optimism, kovan optimism, arbitrum, abitrum rinkeby Reduce code duplication by moving network constants to their own networks Add dash between currency and network

Add networks and reduce network creation code duplication

kvbik · 2021-09-03T19:57:20Z

Cannot create issues in the original reporitory, so here you are:

The payemnt.Ethereum.is_allowed() can bite you pretty hard - it needs to be documented what are the all things you need to setup to make the plugin work:

upload list of eth addresses
create all the other admin configuration!!!

Ideally it should not fail 500 Internal Server Error when the configs are not in place. You should do at least something like json.loads(settings.get( 'VALUE', default='{}'))... one piece of inspiration is the pretix code itself https://github.com/pretix/pretix/blob/master/src/pretix/base/payment.py#L162

rahul-kothari · 2021-09-03T23:26:49Z

@kvbik good idea - done!

also do not use angle brackets, since they are interpretted as html :)))

tiny fix for help text of the plugin settings

payment_pending_render So when users open the payment pending render link from their emails, no error happens since all data is pulled up for the order table.

So that servers can run without any stop.

rahul-kothari · 2021-09-26T17:01:15Z

Amongst others we can close 3 issues:

#53
#7
#5

README.md

pretix_eth/management/commands/confirm_refunds.py

pretix_eth/network/helpers.py

Update README to be non USD centric Improve comments in management commands Remove @chain_id in erc_681 urls for L1 mainnet Remove input currency parameter for uniswap since it is unused

kvbik

LGTM, great work! 👍

rahul-kothari and others added 30 commits June 17, 2021 15:48

improve readme setup instructions, remove eth-hash version requiremen…

ddff451

…t, add venv to gitignore

Add basic implementation for new networks

7563b0c

Change ethereum class name to L1

a20a51f

Hard code network configuration to improve readability

f1aca98

add version range for eth-hash in setup.py remove addresses.txt in gitignore

make version range compatible with eth-utils requirements

fbca654

Add Ethereum L1 class implementation to networks, refactor payments.p…

afce5c6

…y for multiple networks Remove SAI and use DAI for L1

add rinkeby

a48ee64

use class variables

9c8f99d

add class varaibles, clean up constructors, do formatting

12ed7b2

add verbose names to classes, add admin settings for networks

717b36c

add network name to pending.html

926158e

lint and format payments.py

dde939f

add RPC URLs field on settings and update is_allowed()

c4e5308

confirm payments refactor + linting

7eb0bc3

refactor confirm-refunds, lint, fix imports

e212cf7

refactor payment instructions to helpers for usability and add multi-…

0c3c870

…token like functionality

add kovan optimism

4244a3b

fix formatting

e7cb0e0

fix bugs in helpers

2ffaefe

add token based classes and refactor till payment options

b865bc6

refactor

236cae0

tokens - add balance method, add more class variables (is native asse…

319fce8

…t), validation, comments, mappings, payments - rename TOKEN_RATES, fix bugs, reduce functionality

update management commands

0f01189

delete networks.py, unused helpers

147566b

move final_price code from payments to tokens

450a848

simplify token class definitions

8cce8e0

with such a great and generic helpers, there is no need repeat the `payment_instructions` method its only change was if it was using or not the chain_id and used token address or not which is all covered in the helpers already

use address when not native token in uniswap_url

f4327db

Merge pull request #5 from kvbik/currency_reaarch-simplify-class-defi…

a6e41a4

…nitions simplify token class definitions

Merge pull request #3 from rahul-kothari/currency_reaarch

9bd2b8c

add token based classes and refactor till payment options

fix python syntax and make_erc681 token addr error

83fba30

rahul-kothari added 3 commits September 1, 2021 00:09

Add networks and reduce network creation code duplication

34bc7af

Add optimism, kovan optimism, arbitrum, abitrum rinkeby Reduce code duplication by moving network constants to their own networks Add dash between currency and network

Merge pull request #6 from rahul-kothari/more_stuff

95d3c93

Add networks and reduce network creation code duplication

fix tests

ab3cfe9

rahul-kothari added 5 commits September 3, 2021 23:51

update docs with event set up instructions

3205e80

add goerli

3621b5e

Change token rates to be written as USD per token

4d2d8e4

Change token rates to be written as USD per token

ec013b7

set default empty values for admin settings to prevent 500 errors

f892030

kvbik and others added 9 commits September 5, 2021 09:56

settings is using NETWORK_IDENTIFIER

c335357

also do not use angle brackets, since they are interpretted as html :)))

Merge pull request #7 from kvbik/help-text-fix

ae3e9b6

tiny fix for help text of the plugin settings

update readme, fix bug in payment about using json module

f9a6a64

check all events in mgmt commands

9e3ddfc

WIP add token tests

0ef88f8

uncomment require-web3 flag in confirm-refunds tests

ba9a2b0

Use payment order for currency instead of request.session for

337967f

payment_pending_render So when users open the payment pending render link from their emails, no error happens since all data is pulled up for the order table.

Skip asking user for rpc urls in the management commands

9b0cda6

So that servers can run without any stop.

fix tox lint errors

186f857

ligi requested changes Sep 28, 2021

View reviewed changes

Resolve code review comments

bbae2bb

Update README to be non USD centric Improve comments in management commands Remove @chain_id in erc_681 urls for L1 mainnet Remove input currency parameter for uniswap since it is unused

kvbik approved these changes Sep 30, 2021

View reviewed changes

rahul-kothari requested a review from ligi September 30, 2021 20:29

ligi merged commit 19c2efc into efdevcon:master Sep 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add L2 networks - basic #151

Add L2 networks - basic #151

rahul-kothari commented Sep 1, 2021

kvbik commented Sep 3, 2021

rahul-kothari commented Sep 3, 2021

rahul-kothari commented Sep 26, 2021

kvbik left a comment

Add L2 networks - basic #151

Add L2 networks - basic #151

Conversation

rahul-kothari commented Sep 1, 2021

What was wrong?

How was it fixed?

Cute Animal Picture

kvbik commented Sep 3, 2021

rahul-kothari commented Sep 3, 2021

rahul-kothari commented Sep 26, 2021

kvbik left a comment

Choose a reason for hiding this comment