Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing floating point numbers in tests : comparing difference instead of using == #516

Open
pgrt opened this issue Jun 10, 2022 · 0 comments
Labels

Comments

@pgrt
Copy link

pgrt commented Jun 10, 2022

Hello,

In the hypervolume tests, some double are compared using ==, which can lead to test failures as it is safer to compare them by checking that their difference is small.
In the attached patch I changed some of these tests so that the failing tests now pass, but there remains some other such tests to change I think.

Best,
Pierre

check_equality_floating.txt

@pgrt pgrt added the bug label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant