Validation with inherit

[AntonyDeveau]

Hi,

I have a model 'property' and 'flat'.
Flat inherits from property, but when i declare validations in both, only 'Flat' validators show, because they are rewritten.
How can I use validations from the parent in the child class?

[esbanarango]

#33

[GabrielCW]

@AntonyDeveau and I came across a solution for simple cases of inheritance. It goes no further than exporting and merging validation properties, but it's a start.

Here's an example:

parent.js

export let validations = {
  aFieldInTheParent: {
    presence: {message: 'This field must be there'}
};

export default Resource.extend({
  aFieldInTheParent: DS.attr('string'),
  validations: validations
});

child.js

import Parent from './parent';
import { parentValidations } from './parent';

export default Parent.extend({
  aFieldInTheChild: DS.attr('number'),
  validations: Ember.merge(parentValidations, {
    aFieldInTheChild: {
      numericality: {
        greaterThan: 0,
        message: 'This must be greater than 0.'
      }
    }
  })
});

Note that we haven't tested whether added validations on then parent's fields in the child work. This depends on how Ember.merge works, although this can be overriden by your own merging logic.

Hope that may help someone (@NullVoxPopuli)

[NullVoxPopuli]

thanks for the merging idea!

[GabrielCW]

Turns out merging as I wrote it actually changed the parent's validations and put the child's instead.
Validations should actually be copied first, like so:

child.js

import Parent from './parent';
import { parentValidations } from './parent';

export default Parent.extend({
  aFieldInTheChild: DS.attr('number'),
  validations: Ember.merge(Ember.copy(parentValidations, true), {
    aFieldInTheChild: {
      numericality: {
        greaterThan: 0,
        message: 'This must be greater than 0.'
      }
    }
  })
});