Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

Custom x and y accessors #81

Closed
esbullington opened this issue Feb 9, 2015 · 2 comments
Closed

Custom x and y accessors #81

esbullington opened this issue Feb 9, 2015 · 2 comments

Comments

@esbullington
Copy link
Owner

We've been kind of assuming people will use x and y as the names of their respective data names, which is pretty inflexible. We should probably let them specify a custom x and y accessor. So, they could do something like:

<Chart x_accessor="event_dates" y_accessor="event_values" />

And then instead of using point.x and point.y, we'd use point.[props.x_accessor] etc.

Does this sound reasonable?

@yang-wei
Copy link
Collaborator

Yeah this sounds true. Same thing for label and value too ?

@esbullington
Copy link
Owner Author

Done for x and y accessors. I'm still thinking about label and value accessors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants