Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison with perceiver-pytorch? #1

Closed
xloem opened this issue Sep 4, 2021 · 3 comments
Closed

Comparison with perceiver-pytorch? #1

xloem opened this issue Sep 4, 2021 · 3 comments
Assignees

Comments

@xloem
Copy link

xloem commented Sep 4, 2021

How does this repository compare with https://github.com/lucidrains/perceiver-pytorch ?

Would you have any interest in generalizing and integrating the two implementations together?

@esceptico
Copy link
Owner

How does this repository compare with https://github.com/lucidrains/perceiver-pytorch ?

Hey! They differ mainly in the structure of the code.
My version is closer to how the codebase is structured in the DeepMind source repo (link) and in the Transformers library.
There are also differences in how encoder and decoders relate. In lucidrains repo encoder and decoders are not separated. In this repository, they are separated, which allows to combine different encoder-decoder architectures.
Also lucidrains repo contains more data processing utilities for Perceiver IO (like Fourier positional encoding).

Would you have any interest in generalizing and integrating the two implementations together?

I don't think they can be combined :)
But I would like to have an implementation (no matter whose) Perceiver IO in the Transformers library

@xloem
Copy link
Author

xloem commented Sep 4, 2021

I don't think they can be combined :)

Well it sounds like it would mean deciding on a code architecture and adding the features offered by one project into the other project. Since they've already been implemented in one less skill would be needed to do the re-/factoring into the other.

But I would like to have an implementation (no matter whose) Perceiver IO in the Transformers library

Yeah that sounds pretty helpful. Do you think you'll be opening a PR?

@esceptico esceptico self-assigned this Sep 28, 2021
@esceptico
Copy link
Owner

As mentioned here

@NielsRogge is currently working on it

so I hope perceiver io will be part of transformers library soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants