Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser-based completion and assistance #209

Open
esdmr opened this issue Sep 10, 2023 · 0 comments
Open

Parser-based completion and assistance #209

esdmr opened this issue Sep 10, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@esdmr
Copy link
Owner

esdmr commented Sep 10, 2023

Currently, for completion, we send the whole script up to the cursor to fish, and for assistant we use a rather horrible RegExp to parse stuff, which has a ton of false negatives (and hopefully no false positives).

What if we were to create a parser for fish shell and use that to find functions and variables and only send the current command to fish to complete? It also fixes any problem with finding the selected argument and if and while statements, which are broken for some reason.

Edit: See https://github.com/esdmr/fish-parsing-parables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

1 participant