New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailto link is broken esdoc-publish-html-plugin ManualDocBuilder.js #44

Open

niwin opened this issue Dec 6, 2017 · 0 comments

niwin commented Dec 6, 2017 •

edited

Loading

In esdoc-publish-html-plugin/src/Builder/ManualDocBuilder.js

$root.find('a').each((i, el) => {
  const $el = (0, _cheerio2.default)(el);
  const href = $el.attr('href');
  if (!href) return;
  if (href.match(/^http[s]?:/)) return;
  if (href.charAt(0) === '/') return;
  if (href.charAt(0) === '#') return;
  $el.attr('href', `./manual/${href}`);
});

This code adds './manual/' to the mailto address inside of:
<a href="mailto:asdf@asdf.com">asdf@asdf.com</a>

which breaks the link. Please help to fix this. Maybe add a line:

if (href.match(/^mailto:)) return;

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment