Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styled-components refresh entire page #7

Closed
mnemanja opened this issue Mar 11, 2020 · 2 comments
Closed

Styled-components refresh entire page #7

mnemanja opened this issue Mar 11, 2020 · 2 comments

Comments

@mnemanja
Copy link

Hi there,
I've implemented fast-refresh in my CRA following the documentation.
It works when I make a change in a React component, but when I change the styled-component's style it does a whole page refresh.

e.g.
image

@esetnik
Copy link
Owner

esetnik commented Mar 11, 2020

@mnemanja I think this should be reported to pmmmwh/react-refresh-webpack-plugin as it sounds like a bug in the underlying react-refresh webpack implementation and not related to customize-cra-react-refresh.

@mnemanja
Copy link
Author

mnemanja commented Apr 8, 2020

Seems this was some sort of bug that was self resolved since then.

@mnemanja mnemanja closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants