Skip to content
This repository has been archived by the owner on Feb 7, 2022. It is now read-only.

Rename and sort folder structure #55

Closed
joshghent opened this issue Feb 21, 2017 · 11 comments · Fixed by #92
Closed

Rename and sort folder structure #55

joshghent opened this issue Feb 21, 2017 · 11 comments · Fixed by #92
Projects

Comments

@joshghent
Copy link
Collaborator

I've noticed that the whole folder structure we have for the project might be a bit confusing. Some people initially think that we should change things in static/ (which was true for a while). Nonetheless, I think this could be done to be much less confusing.

I was thinking of doing the following changes

  • Rename static to 'dest' or 'dist'
  • Create a folder inside 'src' for 'js' and 'views'
  • Move api.js to a 'server' folder
  • Move all docs (apart from README) into a docs folder.

This might be quite a big job as all the file paths will need renaming. Please make sure you test throughly before submitting a PR! 💃

@amandaporto
Copy link

I'd like to take a shot at this in the next few days :)

@joshghent
Copy link
Collaborator Author

@amandaporto Brilliant, look forward to your PR 👍 Let me know if you need any help.

@joshghent joshghent added 3.0.0 and removed 3.0.0 labels Feb 22, 2017
@SaraVieira SaraVieira added this to In Progress in ESFiddle Feb 26, 2017
@SaraVieira
Copy link
Member

@amandaporto Are you still working on this ?

@amandaporto
Copy link

amandaporto commented Feb 28, 2017

Yes @SaraVieira! This past weekend was a bit busy. Will get it done asap.

@SaraVieira
Copy link
Member

Awesome 🎉

And don't worry, you have time 😄

@vcapretz
Copy link

vcapretz commented Mar 3, 2017

@amandaporto hey Amanda, how are you?

just reminding you that if you need any help just let us know! thanks for working on that

@amandaporto
Copy link

amandaporto commented Mar 3, 2017

@vcapretz Should I keep the LICENSE file in the root with the README, or do you also want it inside the docs folder?

EDIT: Also wanted clarification on Create a folder inside 'src' for 'js' and 'views'. There already is a src/js, so I'll create src/views and move html documents in there. I wanted to double check if you wanted me to move authenticated.js and index.js into src/js or if they should stay where they are.

@vcapretz
Copy link

vcapretz commented Mar 3, 2017

@amandaporto I think you could keep the LICENSE file under the root 😃

in the src folder there's also a examples folder containing some JS files, those ones and the authenticated.js should be inside the src/js folder!

thanks for helping!

@amandaporto
Copy link

amandaporto commented Mar 3, 2017

@vcapretz You still want to keep the example folder, but just under src/js, correct? And just to double check, authenticated.js goes in that folder, but not index.js.

I should be mostly done after this. PR should be coming soon.

@vcapretz
Copy link

vcapretz commented Mar 3, 2017

@amandaporto yeah! that's right.

why not index.js? I think it would make sense to put it under the src/js folder

@amandaporto amandaporto mentioned this issue Mar 3, 2017
10 tasks
@amandaporto
Copy link

No particular reason, it was just how I understood what you said :) PR #92

@joshghent joshghent moved this from In Progress to Code Review in ESFiddle Mar 6, 2017
@joshghent joshghent moved this from Code Review to Version 3.0 in ESFiddle Mar 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
ESFiddle
Version 3.0
Development

Successfully merging a pull request may close this issue.

4 participants