-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
500 server error with wildcard facets #54
Comments
Hi @pochedls , thanks for raising this. It looks like the underlying search interface has been modified and where we used a '*' we now need 'null'. You can patch your local copy with: Lines 200-201 of:
I'll run the tests to check this doesn't have other unwanted consequences. |
Thanks for taking a look @agstephens. I'm wondering if it would be possible to remove facets from the API request if it isn't specified. For example,
would query using the following URL: |
Hi I am also having this issue. I believe it would be helpful to not require a facets=null inclusion, and just have that be the default instead of returning a 500 error whenever facets is not defined in the constructor (examples posted on readthedocs do not work, for example). Thanks! |
@alaniwi: please report here on the issue identified with the Index Node functionality (i.e. the server-side issue). |
@soay do you have a comment on this? |
First of all, we have not changed anything, search is still working with I've modified esg-search some months ago not to return the pid and citation, so In any way, it's still bad practice to use this. This is not a Solr feature, it's just the bad esg-search design that allows it. Given the re-structuration of ESGF I'm not sure it it's worth to invest time to change esg-search ...? |
@soay thanks for clarifying 😄 I'm closing this. |
I am trying to get started with some simple queries and I noticed that if I don't give a value for "facets" I get a 500 Server Error:
But if I set a value for facets (e.g.,
ctx = conn.new_context(variable='tas', time_frequency='mon', facets='null')
), the search is returned successfully.I think
%2A
, which appears to be the default value for facets should interpreted as a wildcard (*
).Is this expected behavior? Should I just specify some null value for facets (e.g., 0)?
The text was updated successfully, but these errors were encountered: