Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new classes to represent statistical data #3

Closed
pantaray opened this issue Jan 17, 2020 · 1 comment
Closed

Include new classes to represent statistical data #3

pantaray opened this issue Jan 17, 2020 · 1 comment
Assignees
Labels
Design Proposal to investigate/change code structure/layout

Comments

@pantaray
Copy link
Member

To adequately represent the result of averaging or pairwise connectivity analyses, a new class structure is needed. Similar to the already existing (abstract and concrete) classes, the following inheritance tree needs to be implemented:

graph TD
BaseData-->AnalogData;
BaseData-->SpectralData;
BaseData-->StatisticalData;
ABC-->StatisticalData;
AnalogData-->TimelockData;
StatisticalData-->|+avg +var +cov +dof|TimelockData
SpectralData-->FreqDescriptivesData;
StatisticalData-->|+avg +var +cov +dof| FreqDescriptivesData;
StatisticalData-->|+chan1 +chan2| ConnectivityData;
ConnectivityData-->|+freq| SpectralConnectivityData;

image

where StatisticalData is an (at the moment) empty abstract class. All other classes are instantiable and provide (at least) the following attributes (inheritance as indicated by above diagram):

TimelockData.avg
TimelockData.var
TimelockData.cov
TimelockData.dat

ConnectivityData.chan1
ConnectivityData.chan2

SpectralConnectivityData.freq
@pantaray pantaray added the Design Proposal to investigate/change code structure/layout label Jan 17, 2020
@pantaray pantaray added this to To Do in Syncopy Dev Pipeline Jan 17, 2020
@pantaray pantaray moved this from To Do to In Progress in Syncopy Dev Pipeline Jan 17, 2020
@joschaschmiedt
Copy link
Collaborator

The basic concept was implemented in 1a33fbd wihoutt any tests. The usable classes will follow in separate classes (#33 for TimelockData).

Syncopy Dev Pipeline automation moved this from In Progress to Done Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Proposal to investigate/change code structure/layout
Projects
No open projects
Development

No branches or pull requests

2 participants