Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/fleets/{fleet_id}/members/ does not mention role requirements in api description #985

Open
3 of 4 tasks
bahrmichael opened this issue Jun 25, 2018 · 3 comments
Open
3 of 4 tasks

Comments

@bahrmichael
Copy link

bahrmichael commented Jun 25, 2018

Inconsistency

The description of fleet endpoints (e.g. /fleets/{fleet_id}/members/) do not mention which fleet role (probably fleet boss) is required to get any meaningful information.

The fleet does not exist or you don’t have access to it gets close, but may be misunderstood.

Routes

  • GET /fleets/{fleet_id}/*

Resolution

Mention that one requires fleet boss.

Checklist

Check all boxes that apply to this issue:

@Aidansavage
Copy link

This would be applicable to all of the fleet endpoints aside from /characters/{character_id}/fleet/ as that one only gives a fleet_id to users.

@bahrmichael
Copy link
Author

@Aidansavage updated the description

@ppetermann
Copy link

I just ran into this, so this how it is supposed to work, it's just not properly documented? because I was about to open a ticket saying it doesn't work..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants