Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glassfish v3 has deprecated asadmin syntax #1

Closed
emkayonline opened this issue Nov 3, 2010 · 5 comments
Closed

Glassfish v3 has deprecated asadmin syntax #1

emkayonline opened this issue Nov 3, 2010 · 5 comments
Labels
Milestone

Comments

@emkayonline
Copy link

When using asadmin to deploy, etc with glassfish v3 a warning "deprecated syntax" is shown.
This is because the action command now comes after the generic parameters. i have made the change in my fork and wondered if you would like to pull it into your main branch.
Change:
emkayonline@17c0eee

@eskatos
Copy link
Owner

eskatos commented Nov 3, 2010

Hello emkayonline,

Thanks for taking the time looking at the code.
BTW, this project support Glassfish V2 only right now.
Do your changes work with a V2 install ?

/Paul

@emkayonline
Copy link
Author

I've just tried it on glassfish 2.1.1 and sadly glassfish v2 doesn't like the command in the different order. So I will keep my fork for glassfish 3.

@eskatos
Copy link
Owner

eskatos commented Nov 10, 2010

Thanks for trying this. I do not have the need for Glassfish v3 support for now but it will raise sooner or later and this project will have to be refactored in order to support both v2 and v3.

As you are using it against a v3, I'm interested about reading about your findings if you come accross other incompatibilities.

@emkayonline
Copy link
Author

OK, np. It is working well so far with the little change in command line argument order. nice plugin by the way - clean and simple for glassfish users compared to cargo.

@eskatos
Copy link
Owner

eskatos commented Dec 16, 2010

Duplicate of #2

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants