Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require-description shouldn't require a description for eslint-enable #131

Closed
DetachHead opened this issue Oct 15, 2023 · 3 comments
Closed
Labels

Comments

@DetachHead
Copy link

when using eslint-enable, there's already an eslint-disable comment with the description on it so there's no reason to provide another description when re-enabling it.

describe('any', () => {
    /* eslint-disable @typescript-eslint/no-explicit-any -- testing the any type */
    test('pass', () => {
        exactly<any>()(any)
    })
    test('fail', () => {
        // @ts-expect-error doesn't match
        exactly<any>()(number)
        // @ts-expect-error doesn't match
        exactly<number>()(any)
    })
    /* eslint-enable @typescript-eslint/no-explicit-any -- testing the any type */
})

original issue: mysticatea#61

@dimitropoulos
Copy link

this seems the same as: mysticatea#49

which is to say: I 100% agree!

@tylerlaprade
Copy link

I have always used it like this, using this config:
"eslint-comments/require-description": ["error", { "ignore": ["eslint-enable"] }],

@github-actions github-actions bot added the Stale label Dec 15, 2023
Copy link

This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that aren't actionable. Please reach out if you have more information for us! 🙂

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants