-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint-comments/require-description
should allow ignoring particular rules
#134
Comments
Ran into this need in my codebase; we have a variable we use throughout the app which causes a render-loop if we add it as a React hook dependency, so we ended up with quite a few I've popped up a PR for this. |
Thank you very much for the PR, @mcongrove! It sounds like your use case would be better served by a variable-name exclusion for that particular rule, though, so that the rule would still work on other variables. |
I over-simplified a bit for the example; it's actually quite a few variables. It's probably indicative of a bigger issue in the libraries we choose and how we utilize hooks, but I'm just in charge of linting rules :) |
This issue has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from issues that aren't actionable. Please reach out if you have more information for us! 🙂 |
Do they? Developer memory is limited. At some point someone new will see the code and they won't have any context. Comments outlive developers. |
It's very nice that we can ignore categories of
eslint
directives. I would find it very helpful to also be able to ignore particular ESLint rules that we disable for self-evident reasons, such as importing a forbidden library is only allowed in ourui-component
folder.(cloned from mysticatea#76)
The text was updated successfully, but these errors were encountered: