Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reporting location for no-missing-placeholders, no-unused-placeholders #276

Closed
bmish opened this issue Aug 1, 2022 · 0 comments · Fixed by #279 or #280
Closed

Incorrect reporting location for no-missing-placeholders, no-unused-placeholders #276

bmish opened this issue Aug 1, 2022 · 0 comments · Fixed by #279 or #280
Labels

Comments

@bmish
Copy link
Member

bmish commented Aug 1, 2022

For some reason, I'm seeing these rules incorrectly report violations inside meta.messages instead of in the context.report() call in these two examples:

  1. https://github.com/typescript-eslint/typescript-eslint/blob/ff93e6a839f7c34ed8c3b1740a20d37e0e992641/packages/eslint-plugin/src/rules/no-unsafe-argument.ts#L145
  2. https://github.com/typescript-eslint/typescript-eslint/blob/ff93e6a839f7c34ed8c3b1740a20d37e0e992641/packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts#L41

I need to investigate to see what's going on.

@bmish bmish added the bug label Aug 1, 2022
@bmish bmish changed the title Incorrect violation / reporting location for no-missing-placeholders, no-unused-placeholders Incorrect reporting location for no-missing-placeholders, no-unused-placeholders Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant