Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prefer-immutable-types): change the options in recommeneded and lite configs #810

Open
wants to merge 1 commit into
base: 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
Choose a base branch
from
Open

feat(prefer-immutable-types): change the options in recommeneded and lite configs #810

wants to merge 1 commit into from

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Apr 18, 2024 •
edited
Loading

No description provided.

This was referenced Apr 18, 2024
Open
Open
Closed
Open
@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Apr 18, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens mentioned this pull request Apr 18, 2024
Open
@RebeccaStevens RebeccaStevens marked this pull request as ready for review April 18, 2024 08:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f62f410 to 414f358 Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 22, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 9437fe3 to a63f57c Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 414f358 to 389d79d Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from a63f57c to 3563ace Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 389d79d to dd561f5 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 3563ace to 76a233f Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from dd561f5 to 86216cb Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 76a233f to 19b9672 Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 86216cb to 3818253 Compare May 3, 2024 06:36
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 19b9672 to 3e4c47c Compare May 3, 2024 06:36
@RebeccaStevens RebeccaStevens mentioned this pull request May 3, 2024
Closed
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 3818253 to 311970a Compare May 6, 2024 01:01
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 3e4c47c to 7646b39 Compare May 6, 2024 01:01
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 311970a to 86b0162 Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 7646b39 to 265bc68 Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 86b0162 to 8dd704a Compare May 6, 2024 04:13
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 265bc68 to 29fab99 Compare May 6, 2024 04:13
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 8dd704a to 79741ab Compare May 6, 2024 04:18
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 29fab99 to a106b81 Compare May 6, 2024 04:18
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 79741ab to 0903137 Compare May 6, 2024 04:31
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from a106b81 to d0bd5dd Compare May 6, 2024 04:31
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0903137 to 2c6e45b Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from c4d48b9 to ae09f91 Compare June 19, 2024 10:22
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 29ef1f0 to e739b5b Compare June 19, 2024 11:02
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from ae09f91 to ba1b267 Compare June 19, 2024 11:02
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from e739b5b to 8c42a0a Compare June 19, 2024 11:10
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from ba1b267 to f1eaa1d Compare June 19, 2024 11:10
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 8c42a0a to eda6c89 Compare June 24, 2024 11:51
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from f1eaa1d to aa3da6b Compare June 24, 2024 11:52
@RebeccaStevens RebeccaStevens mentioned this pull request Jun 24, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from eda6c89 to f42398c Compare June 30, 2024 07:11
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from aa3da6b to 54ea563 Compare June 30, 2024 07:11
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f42398c to d19e712 Compare June 30, 2024 08:25
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 54ea563 to 9b1187c Compare June 30, 2024 08:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d19e712 to 0f0ff14 Compare July 5, 2024 09:16
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 9b1187c to d385a79 Compare July 5, 2024 09:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0f0ff14 to 737b653 Compare July 6, 2024 02:25
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from d385a79 to 209fa80 Compare July 6, 2024 02:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 737b653 to f742b89 Compare July 6, 2024 03:44
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 209fa80 to a47d439 Compare July 6, 2024 03:44
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f742b89 to b574f86 Compare July 10, 2024 14:41
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from a47d439 to 62cdedb Compare July 10, 2024 14:41
@RebeccaStevens RebeccaStevens mentioned this pull request Jul 10, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from b574f86 to a59dff0 Compare July 11, 2024 08:04
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 62cdedb to bc95835 Compare July 11, 2024 08:04
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a59dff0 to 35d4d4d Compare July 11, 2024 08:29
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from bc95835 to 3155181 Compare July 11, 2024 08:29
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 35d4d4d to aa820a1 Compare July 11, 2024 10:41
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 3155181 to af28b85 Compare July 11, 2024 10:41
@RebeccaStevens
feat(prefer-immutable-types): change the options in recommeneded and …
924db41 
…lite configs

Recommended: Parameters must be deeply readonly when typed with a type defined in a local file.
Types defined in packages in the ts lib must be readonly shallow.

Lite: Parameters must be shallowly readonly when typed with a type defined in a local file.
There is no enforcement on types defined elsewhere.
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from aa820a1 to 1c51ad1 Compare July 26, 2024 04:22
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from af28b85 to 924db41 Compare July 26, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RebeccaStevens