Skip to content
This repository has been archived by the owner on May 22, 2022. It is now read-only.

Plugin collision occurs when trying to use base and typescript configs #13

Closed
Tauka opened this issue May 14, 2021 · 2 comments
Closed

Comments

@Tauka
Copy link

Tauka commented May 14, 2021

Hello, thank you for this package! I have faced an error when trying to use both /base and /typescript configs,

Oops! Something went wrong! :(

ESLint: 7.26.0

ESLint couldn't determine the plugin "import" uniquely.

- /Users/tauka/Documents/dynamik/robotmation/three-editor/node_modules/@eslint-kit/eslint-config-typescript/node_modules/eslint-plugin-import/lib/index.js (loaded in ".eslintrc.js » @eslint-kit/eslint-config-typescript")
- /Users/tauka/Documents/dynamik/robotmation/three-editor/node_modules/@eslint-kit/eslint-config-base/node_modules/eslint-plugin-import/lib/index.js (loaded in ".eslintrc.js » @eslint-kit/eslint-config-base")

Please remove the "plugins" setting from either config or remove either plugin installation.
@risen228
Copy link
Collaborator

@Tauka Hello! It's not the @eslint-kit's issue. Most likely, your starter (cra, gatsby, etc) has eslint-import-plugin inside, which is why versions conflict in some way. I need information about what exactly you are using and I can help.

@Tauka
Copy link
Author

Tauka commented May 15, 2021

I was able to reproduce error in minimal repo: https://github.com/Tauka/eslint-config-kit-issue

Seems like issue only occurs when you install eslint-plugin-import as your dependency even though it is not added to .eslintrc.js. When I remove it (npm uninstall or yarn remove), it works fine. I still think this behavior is incorrect, if someone has eslint-plugin-import installed in their node_modules, then those configs won't work.

Also, I tried to remove "import" plugin from one of the conflicting configs (either base or typescript), and it worked for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants