-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
become the defacto functional-programming eslint plugin. #1
Comments
@idmitriev I've noticed you've accepted my invite to eslint-plugin-cleanjs, what are your thoughts on moving eslint-plugin-better over to eslint-plugin-cleanjs ? |
That looks promising, but there are a lot of rules and I'm not sure how it brings these projects together (though it seems to be a fork of |
It's actually a fork of eslint-plugin-fp, you can see the rules imported from eslint-plugin-better: 64fb977
I disagree, it would be better to have one fp config and ruleset with a big active team behind it.
I do too. I just need @jfmengels to agree to merge with this project. |
I see, how about we turn the list of rules into a table showing the origin of each rule? I appreciate the idea of simplifying these packages into one, but it's more likely that one or two packages would be merged than all of them IMO. Duplicating code from another project that does not want to merge would create maintenance burden for both projects, and could cause difficult merge conflicts. I would prefer to have this package depend on those packages and provide one config as a convenience, not copying any code except from projects that are confirmed to be transitioning. |
@nickmccurdy you can just use eslint-preset-cleanjs for that. |
Either way, I think it would be easier to make the transition gradually from the bottom up (by merging individual projects one by one). I may make a PR to fix idmitriev/eslint-plugin-better#4, but I will continue to watch this project. Thanks. |
@graingert I'm sorry, I totally forgot about jfmengels/eslint-plugin-fp#32, I'll take a look at it. |
The text was updated successfully, but these errors were encountered: